Chris Wilson <[email protected]> writes: > The intention of checking obj->gtt_offset!=0 is to verify that the > target object was listed in the execbuffer and had been bound into the > GTT. This is guarranteed by the earlier rearrangement to split the > execbuffer operation into reserve and relocation phases and then > verified by the check that the target handle had been processed during > the reservation phase. > > However, the actual checking of obj->gtt_offset==0 is bogus as we can > indeed reference an object at offset 0. For instance, the framebuffer > installed by the BIOS often resides at offset 0 - causing EINVAL as we > legimately try to render using the stolen fb.
We've never triggered this check in practice, as far as I know, so I'm happy to see it go. Reviewed-by: Eric Anholt <[email protected]>
pgpYPmBoQ3ATR.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
