>-----Original Message----- >From: Chris Wilson [mailto:[email protected]] >Sent: Thursday, April 19, 2018 2:13 PM >To: Shi, Yang A <[email protected]>; Jani Nikula ><[email protected]>; >[email protected] >Subject: RE: [Intel-gfx] [PATCH] drm/i915: Refine the has_audio assignment > >Quoting Shi, Yang A (2018-04-19 02:22:33) >> >-----Original Message----- >> >From: Jani Nikula [mailto:[email protected]] >> >Sent: Wednesday, April 18, 2018 8:44 PM >> >To: Chris Wilson <[email protected]>; Shi, Yang A >> ><[email protected]>; [email protected] >> >Cc: Shi, Yang A <[email protected]> >> >Subject: Re: [Intel-gfx] [PATCH] drm/i915: Refine the has_audio >> >assignment >> > >> >On Fri, 13 Apr 2018, Chris Wilson <[email protected]> wrote: >> >> Quoting Yang (2018-04-13 05:06:45) >> >>> From: Yang Shi <[email protected]> >> >>> >> >>> Refine the has_audio assignment for dp and hdmi. >> >> >> >> s/Refine/Ignore the user override for/ >> >> >> >> Why? >> > >> >Yang, we'll need the explanation before we continue with review or >> >even consider merging. We routinely ignore patches where questions go >> >unanswered. >> > >> >BR, >> >Jani. >> >> This code change is just to make driver code more readable. >> If(condition) value = a else value = condition looks redundancy. > >Read the patch again, AUTO != ON. >-Chris
Yes, I make a mistake and misunderstand such code. BR. Yang. _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
