>-----Original Message----- >From: Ville Syrjala [mailto:[email protected]] >Sent: Friday, February 23, 2018 3:12 AM >To: [email protected] >Cc: [email protected]; Mihail Atanassov ><[email protected]>; Liviu Dudau <[email protected]>; Brian >Starkey <[email protected]>; Mali DP Maintainers ><[email protected]>; Lin, Johnson <[email protected]>; Shankar, Uma ><[email protected]>; Sharma, Shashank <[email protected]> >Subject: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude >representation > >From: Ville Syrjälä <[email protected]> > >The documentation for the ctm matrix suggests a two's complement format, but >at least the i915 implementation is using sign-magnitude instead. And looks >like >malidp is doing the same. Change the docs to match the current implementation, >and change the type from __s64 to __u64 to drive the point home. >
Looks ok to me. Reviewed-by: Uma Shankar <[email protected]> >Cc: [email protected] >Cc: Mihail Atanassov <[email protected]> >Cc: Liviu Dudau <[email protected]> >Cc: Brian Starkey <[email protected]> >Cc: Mali DP Maintainers <[email protected]> >Cc: Johnson Lin <[email protected]> >Cc: Uma Shankar <[email protected]> >Cc: Shashank Sharma <[email protected]> >Signed-off-by: Ville Syrjälä <[email protected]> >--- > include/uapi/drm/drm_mode.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h >index 2c575794fb52..b5d7d9e0eff5 100644 >--- a/include/uapi/drm/drm_mode.h >+++ b/include/uapi/drm/drm_mode.h >@@ -598,8 +598,11 @@ struct drm_mode_crtc_lut { }; > > struct drm_color_ctm { >- /* Conversion matrix in S31.32 format. */ >- __s64 matrix[9]; >+ /* >+ * Conversion matrix in S31.32 sign-magnitude >+ * (not two's complement!) format. >+ */ >+ __u64 matrix[9]; > }; > > struct drm_color_lut { >-- >2.16.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
