Quoting Jackie Li (2018-02-09 01:03:52)
> CNL has its specific reserved GuC WOPCM size for RC6 and other hardware
> contexts.
>
> This patch updates the code to return CNL specific reserved GuC WOPCM size
> for RC6 and other hardware contexts so that the GuC WOPCM size can be
> calculated correctly for CNL.
>
> v9:
> - Created a new patch for these changes originally made in v8 4/6 patch of
> this series (Sagar/Michal)
>
> Cc: Sagar Arun Kamble <[email protected]>
> Cc: Michal Wajdeczko <[email protected]>
> Cc: Chris Wilson <[email protected]>
> Cc: Joonas Lahtinen <[email protected]>
> Signed-off-by: Jackie Li <[email protected]>
<SNIP>
> diff --git a/drivers/gpu/drm/i915/intel_guc_wopcm.c
> b/drivers/gpu/drm/i915/intel_guc_wopcm.c
> index 8b2ce49..d0185b0 100644
> --- a/drivers/gpu/drm/i915/intel_guc_wopcm.c
> +++ b/drivers/gpu/drm/i915/intel_guc_wopcm.c
> @@ -34,6 +34,9 @@ static inline u32 guc_wopcm_context_reserved_size(struct
> intel_guc *guc)
> if (IS_GEN9_LP(i915))
> return BXT_GUC_WOPCM_RC6_CTX_RESERVED;
>
> + if (IS_GEN10(i915))
> + return CNL_GUC_WOPCM_HW_CTX_RESERVED;
> +
> return 0;
> }
>
This should maybe be a if-else ladder, with the last branch applying to
any Gen10+, as it's a reasonable expectation that size is what it was in
the previous platform (or is it?). So;
if (gen9_lp)
...
else if (gen => 10)
...
Reviewed-by: Joonas Lahtinen <[email protected]>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
