On 01/31/2018 11:41 PM, Chris Wilson wrote:

  - Fixed patch format issues

Cc: Michal Wajdeczko <[email protected]>
Cc: Chris Wilson <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Signed-off-by: Jackie Li <[email protected]>
---
+static inline bool __reg_locked(struct drm_i915_private *dev_priv,
+                               i915_reg_t reg)
+{
+       return !!(I915_READ(reg) & GUC_WOPCM_REG_LOCKED);
Why the double cast to bool?
My thought was the code would be clearer to use bool as the return type and
have a explicit cast to bool. Are you suggesting I should use a return type such as *int*
and remove the double cast?

Regards,
-Jackie

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to