On Sat, 11 Nov 2017 01:06:31 +0100, Sujaritha Sundaresan <[email protected]> wrote:

Unifying the various seq_puts messages in debugfs to the simplest one for
feature support.

v2: Clarifying the commit message (Anusha)

v3: Re-factoring code as per review (Michal)

v4: Rebase

v5: Split from following patch

v6: Re-factoring code (Michal, Sagar)
    Clarifying commit message (Sagar)

v7: Generalizing subject to drm/i915 (Sagar)

v8: Omitting DRRS seq_puts unification (Michal)

v9: Including the HAS_HUC condition (Michal)
    Updating more functions with unified message (Sagar)

Suggested by : Michal Wajdeczko <[email protected]>
Signed-off-by: Sujaritha Sundaresan <[email protected]>
Cc: Daniele Ceraolo Spurio <[email protected]>
Cc: Michal Wajdeczko <[email protected]>
Cc: Oscar Mateo <[email protected]>
Cc: Sagar Arun Kamble <[email protected]>
---
drivers/gpu/drm/i915/i915_debugfs.c | 53 +++++++++++++++++++++++++------------
 1 file changed, 36 insertions(+), 17 deletions(-)


<snip>

@@ -2361,8 +2361,10 @@ static int i915_huc_load_status_info(struct seq_file *m, void *data)
        struct drm_i915_private *dev_priv = node_to_i915(m->private);
        struct drm_printer p;
-       if (!HAS_HUC_UCODE(dev_priv))
+       if (!HAS_HUC(dev_priv)) {

Hmm, HAS_HUC is not available yet, it will be introduced by patch 2/8

<snip>

@@ -2461,9 +2465,11 @@ static bool check_guc_submission(struct seq_file *m)
        if (!guc->execbuf_client) {
                seq_printf(m, "GuC submission %s\n",
-                          HAS_GUC_SCHED(dev_priv) ?
-                          "disabled" :
-                          "not supported");
+                               HAS_GUC(dev_priv) ?
+                               "not supported" :
+                               NEEDS_GUC_FW(dev_priv) ?

NEEDS_GUC_FW will also be introduced by patch 2/8

Michal
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to