On Sat, 2017-10-14 at 11:12 +0100, Chris Wilson wrote: > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression > that had been lurking for 6 months, so lets try enabling the full set of > warnings for CI builds. This means more patches will be rejected early > that contain trivial and sometimes not so trivial bugs. However, our > code does not yet compile cleanly with W=1, so we have to apply a filter > to the set of warnings until we can eliminate the mistakes. It also > means that developers will have to be running the full gamut of gcc to > ensure that as warnings come and go with gcc updates, we have the CI > build prepared. > > Signed-off-by: Chris Wilson <[email protected]> > Cc: Joonas Lahtinen <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Tomi Sarvela <[email protected]> > Cc: Micahal Wajdeczko <[email protected]> > Cc: Ville Syrjälä <[email protected]>
The first portion (this patch) I can easily agree on. I'm not so sure about the #pragma stuff to move the information to source files. It sounds like making better use of the compiler warnings, but would we maybe want to isolate at file level the ones that have the exemption? Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
