Quoting Daniel Vetter (2017-07-07 11:17:22) > On Fri, Mar 17, 2017 at 12:15 PM, Joonas Lahtinen > <[email protected]> wrote: > > On to, 2017-03-16 at 13:20 +0000, Chris Wilson wrote: > >> Currently, the last object in the execlist is the always the batch. > >> However, when building the batch buffer we often know the batch object > >> first and if we can use the first slot in the execlist we can emit > >> relocation instructions relative to it immediately and avoid a separate > >> pass to adjust the relocations to point to the last execlist slot. > >> > >> Signed-off-by: Chris Wilson <[email protected]> > > > > Reviewed-by: Joonas Lahtinen <[email protected]> > > This patch was reviewed/pushed full month before the mesa patch was > fully reviewed and ready for merging. That's not how uapi is done. > > I've fixed this up now by at least reviewing the mesa patch, but for > next time around: If you review uapi, and you don't make sure the > userspace side is in good shape too, then you've not reviewed the > patch properly.
The userspace was in good shape and had been requested. Now explain the complication in the API that merits a rant? You've had well over 2 years to review the patches that first used it. -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
