>-----Original Message----- >From: Vivi, Rodrigo >Sent: Wednesday, June 7, 2017 2:26 PM >To: Srivatsa, Anusha <[email protected]> >Cc: [email protected] >Subject: Re: [PATCH 2/3] drm/i915/cfl: Add Coffee Lake PCI IDs for H Sku. > >On Wed, 2017-06-07 at 11:24 -0700, Anusha Srivatsa wrote: >> Add PCI Ids for H Sku by following the BSpec. >> >> v2: Remove unused INTEL_CFL_IDS.(Rodrigo). >> >> Cc: Rodrigo Vivi <[email protected]> >> Signed-off-by: Anusha Srivatsa <[email protected]> >> --- >> drivers/gpu/drm/i915/i915_pci.c | 1 + >> include/drm/i915_pciids.h | 3 +++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/i915_pci.c >> b/drivers/gpu/drm/i915/i915_pci.c index 3980305..d0ca63a 100644 >> --- a/drivers/gpu/drm/i915/i915_pci.c >> +++ b/drivers/gpu/drm/i915/i915_pci.c >> @@ -492,6 +492,7 @@ static const struct pci_device_id pciidlist[] = { >> INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info), >> INTEL_CNL_IDS(&intel_cannonlake_info), >> INTEL_CFL_S_IDS(&intel_coffeelake_info), >> + INTEL_CFL_H_IDS(&intel_coffeelake_info), >> {0, 0, 0} >> }; >> MODULE_DEVICE_TABLE(pci, pciidlist); >> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h >> index 5c5699f..2a548b5 100644 >> --- a/include/drm/i915_pciids.h >> +++ b/include/drm/i915_pciids.h >> @@ -329,6 +329,9 @@ >> INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \ >> INTEL_VGA_DEVICE(0x3E92, info) /* SRV GT2 */ >> >> +#define INTEL_CFL_H_IDS(info) \ >> + INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */ >> + > >missing 0x3E9B >with that feel free to include my rv-b
Another look at BSpec confirmed to me that the missing ID is 0x3E95. Patch to follow soon. Anusha >> #define INTEL_KBL_GT4_IDS(info) \ >> INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */ >> _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
