On Tue, 2017-06-06 at 15:44 +0300, [email protected] wrote: > From: Ville Syrjälä <[email protected]> > > We're not that short on characters that we can't spell out > "false_color". Saves me from figuring out what "fc" means > the next time look at the code.
Yeap, even I took a while to remember what was fc last time that I saw this... Reviewed-by: Rodrigo Vivi <[email protected]> > > Cc: Rodrigo Vivi <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c > b/drivers/gpu/drm/i915/i915_debugfs.c > index 8fdb911344b3..a6ba2100bb88 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs.c > +++ b/drivers/gpu/drm/i915/i915_debugfs.c > @@ -1694,7 +1694,7 @@ static int i915_fbc_status(struct seq_file *m, void > *unused) > return 0; > } > > -static int i915_fbc_fc_get(void *data, u64 *val) > +static int i915_fbc_false_color_get(void *data, u64 *val) > { > struct drm_i915_private *dev_priv = data; > > @@ -1706,7 +1706,7 @@ static int i915_fbc_fc_get(void *data, u64 *val) > return 0; > } > > -static int i915_fbc_fc_set(void *data, u64 val) > +static int i915_fbc_false_color_set(void *data, u64 val) > { > struct drm_i915_private *dev_priv = data; > u32 reg; > @@ -1727,8 +1727,8 @@ static int i915_fbc_fc_set(void *data, u64 val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_fc_fops, > - i915_fbc_fc_get, i915_fbc_fc_set, > +DEFINE_SIMPLE_ATTRIBUTE(i915_fbc_false_color_fops, > + i915_fbc_false_color_get, i915_fbc_false_color_set, > "%llu\n"); > > static int i915_ips_status(struct seq_file *m, void *unused) > @@ -4869,7 +4869,7 @@ static const struct i915_debugfs_files { > {"i915_pri_wm_latency", &i915_pri_wm_latency_fops}, > {"i915_spr_wm_latency", &i915_spr_wm_latency_fops}, > {"i915_cur_wm_latency", &i915_cur_wm_latency_fops}, > - {"i915_fbc_false_color", &i915_fbc_fc_fops}, > + {"i915_fbc_false_color", &i915_fbc_false_color_fops}, > {"i915_dp_test_data", &i915_displayport_test_data_fops}, > {"i915_dp_test_type", &i915_displayport_test_type_fops}, > {"i915_dp_test_active", &i915_displayport_test_active_fops}, _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
