On 29 November 2016 at 14:13, <[email protected]> wrote:
> From: Ville Syrjälä <[email protected]>
>
> Looks like we're only initializing dev_priv->atomic_cdclk_freq
> at resume and commit times, not at init time. Let's do that as
> well.
>
> We're now hitting the 'WARN_ON(intel_state->cdclk == 0)' in
> hsw_compute_linetime_wm() on account of populating
> intel_state->cdclk from dev_priv->atomic_cdclk_freq.
> Previously we were mispopulating intel_state->cdclk with
> dev_priv->cdclk_freq which always had a proper value at init
> time and hence the WARN_ON() didn't trigger.
>
> Cc: [email protected]
> Cc: Matthew Auld <[email protected]>
> Reported-by: Matthew Auld <[email protected]>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98902
> Fixes: e0ca7a6be38c ("drm/i915: Fix cdclk vs. dev_cdclk mess when not
> recomputing things")
> Signed-off-by: Ville Syrjälä <[email protected]>
Tested-by: Matthew Auld <[email protected]>
Reviewed-by: Matthew Auld <[email protected]>
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
