On Thu, 22 Sep 2011 17:11:52 -0700, Ben Widawsky <[email protected]> wrote:

> It requires an additional IOMMU patch.

Can we collect those two patches into one sequence?

> +     if ((gpu_devid == PCI_DEVICE_ID_INTEL_IRONLAKE_M_HB ||
> +          gpu_devid == PCI_DEVICE_ID_INTEL_IRONLAKE_M_IG) &&
> +          intel_private.base.needs_dmar)
> +             intel_private.base.do_idle_maps = 1;
> +

I'd like to make this conditional on whether IOMMU is actually in use;
needs_dmar is based solely on whether the DMA_API is compiled into the
kernel and the GTT gen is > 2.

> -     if (lists_empty)
> +     if (lists_empty && !!dev_priv->mm.gtt->do_idle_maps)
>               return 0;

Is it necessary to change the semantic of this function in cases which
aren't related to GTT remapping? Seems like you're imposing a fairly
high cost on operations which don't actually need it.

-- 
[email protected]

Attachment: pgpE8D3cwF6jR.pgp
Description: PGP signature

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to