On Wed, 14 Sep 2011 09:40:50 +0200 Daniel Vetter <[email protected]> wrote:
Paraphrasing: >> PATCH > The code is too bloated It adds bloat, I agree. I haven't run any tests, but I can't imagine it has a runtime impact. Your suggestions feel a lot like the existing code to me, which was not easy to digest. My goal was to make the code easier to understand, and removing the black magic was just part of that. To me it's the most obvious way to understand how the semaphores work, though I could be in the minority. It also provides an easy way to put per ring debug, add new rings, and disable/enable semaphores for a given ring (your idea, which I really like). I don't feel strongly enough about it to argue further than that. I'm cool with letting the patches die if others don't agree. Ben _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
