On Sat, 09 Jul 2011 13:24:02 -0700, Keith Packard <[email protected]> wrote: > On Sat, 9 Jul 2011 09:38:51 +0100, Chris Wilson <[email protected]> > wrote: > > > + /* We have to disable faulting here in case the user address > > + * is really a GTT mapping and so we can not enter > > + * i915_gem_fault() whilst already holding struct_mutex. > > + */ > > I would (far, far) rather disallow pread through the GTT > mapping. There's no credible reason to allow it. Is there some > reasonably fast way to detect that these addresses are within the GTT > and just bail?
That means that I can't give users of GL pointers to GTT mappings for the buffer mapping API, because then I'd have to check in userland whether the pointer they give me for other API entrypoints is to a known GTT mapping before doing a pread into it. And then I imagine cross-API interactions and shudder.
pgpr8urn5O1y3.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
