On Sun, 05 Jun 2011 10:10:39 -0700, Eric Anholt <[email protected]> wrote: > On Sat, 4 Jun 2011 17:06:31 -0700, Chad Versace <[email protected]> wrote: > > Before this commit, if a client were to request a stencil or hiz buffer, > > then > > I830DRI2CreateBuffer() allocated and returned an X-tiled buffer by > > accident. (DRI2BufferStencil and DRI2BufferHiz were unintentionally caught > > by the default case of a switch statement.) > > > > Now, I830DRI2CreateBuffer() correctly returns a Y-tiled buffer and handles > > the stencil buffer as a special case due its quirky pitch requirements. > > > > This shouldn't break older Mesa versions, because they never query (via > > DRI2GetBuffersWithFormat) for the drawable's DRI2BufferStencil. > > > > Signed-off-by: Chad Versace <[email protected]> > > This should make configure.ac depend on the bumped version of > dri2proto.h, so people get an explanation instead of just build failure. > > Also, I'm surprised to see you didn't fix the "we'll allocate a buffer > for *anything*" behavior that made the compat path in Mesa strange this > time around.
Eric, I've fixed the patch series according to your comments and resubmitted. I don't know why I didn't fix the "we'll allocate anything you ask for" problem; guess I was just too busy digging in other things. _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
