Hi!,
When I run the intel_audio_dump tool with my laptop (Core i5 Intel HD
Graphics) seems that it is not correctly fetching the data.
This is a piece of the source, in which the HAS_PCH_SPLIT macro is
called (Line 1197, intel_audio_dump.c)
if (HAS_PCH_SPLIT(devid) || getenv("HAS_PCH_SPLIT")) {
intel_check_pch();
dump_cpt();
} else if (IS_GEN5(devid))
dump_ironlake();
else
dump_eaglelake();
In the HAS_PCH_SPLIT macro is also checked if the device is GEN5, so
in my case, I will never reach the second statement.
I've checked the output of the dump_ironlake() function, and seems to be ok.
As in other files the HAS_PCH_SPLIT macro is used, I'm not pretty sure
about the best solution here.
I simply checked if it is a GEN6 device instead of using the
HAS_PCH_SPLIT macro.
I have attached the change I made.
Regards,
--
Diego Celix
From 11ecef0c415e20c1b377bf9bb93dcc4b1ab283c0 Mon Sep 17 00:00:00 2001
From: Diego Celix <[email protected]>
Date: Tue, 15 Feb 2011 17:17:41 +0000
Subject: [PATCH] intel_audio_dump: Removed repeated check for GEN5
In main(), there is a repeated check for a GEN5 device.
The first one is inside the HAS_PCH_SPLIT macro wich prevents reaching the
correct option.
---
tools/intel_audio_dump.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c
index ef81b6a..c3204a2 100644
--- a/tools/intel_audio_dump.c
+++ b/tools/intel_audio_dump.c
@@ -1194,7 +1194,7 @@ int main(int argc, char **argv)
else
intel_get_mmio(pci_dev);
- if (HAS_PCH_SPLIT(devid) || getenv("HAS_PCH_SPLIT")) {
+ if (IS_GEN6(devid) || getenv("HAS_PCH_SPLIT")) {
intel_check_pch();
dump_cpt();
} else if (IS_GEN5(devid))
--
1.7.3.4
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
