On Wed, 11 Aug 2010 10:14:44 -0400, Adam Jackson <[email protected]> wrote: > On Wed, 2010-08-11 at 10:25 +0100, Chris Wilson wrote: > > To simplify the IS_GEN[234] macros and to enable switching. > > I think your three cent titanium tax doesn't go too far enough. > > 830, 845g, 85x, and 865 all now have > > .gen = 2, > .is_i8xx = 1, > > and nothing later has .is_i8xx, so that field can just go.
Yes. I was just worried about some subtle semantic difference between is_i8xx and is_i9xx and the generation number. I still look at IS_I965G() and shudder. So for the first patch, I wanted something obvious and simple that gave me the ability to switch(INTEL_INFO(dev)->gen). I'd like to replace some of the coarse is_i9xx with more fine-grained capability bits that are more self-descriptive and clear when they can be relied upon. -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
