On Fri, May 14, 2010 at 09:23:02AM +0800, Zou Nan hai wrote: > enable multiple ring buffer support for G45+ chips. > abstract ring buffer structure, add support for BSD(Bit stream decoder) > BSD is a GPU unit used for H.264/VC1 VLD decoding, > > Signed-off-by: Zou Nan hai <[email protected]> > Signed-off-by: Xiang Hai hao <[email protected]>
Just a few things: - When resubmitting patches, please track a version number somewhere (for the whole series + for individual patches, if they change). With complicated stuff like this (which probably needs a few review rounds) it makes life _much_ easier. Also _always_ say what you've changed wrt the last submission (in the intro for the whole series if it's something bigger, in the commit message for individual patches if it's just a implementation detail). - Just because I've complained that your last submission smears stuff all over different patches doesn't mean you have to mould them into one ;) Trying harder to sensibly split them up was the idea I had in mind ... Yep, I'm fully aware that this probably requires a complety rewrite of the bugger. I think I've sufficiently demonstrated with my last attempt at a review that the code as-is too confusing to review. So I'm not gonna make myself a laughing stock by trying again - on a quick lock it seems essentially unchanged. Yours, Daniel -- Daniel Vetter Mail: [email protected] Mobile: +41 (0)79 365 57 48 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
