On Wed, 29 Oct 2003, Phil Chambers wrote: > I am relatively new to cyrus and have only been able to scratch the surface of the > code. However, I noticed an inconsistency in imap/pop3d.c in the use of > mailbox_write_index_header(). At line 1347 of the 2.1.13 version (i.e. if the > interval is less than popminpoll) there in no following mailbox_unlock_index() call. > However, at line 582, there is a following call to mailbox_unlock_index().
mailbox_close() will also unlock all of the files associated with the mailbox context. So the mailbox_close that follows should take care of this problem. > Is ther a potential problem here, given that it still needs a QUIT command to close > down the session, which could be some time? I don't believe so. -Rob -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Rob Siemborski * Andrew Systems Group * Cyert Hall 207 * 412-268-7456 Research Systems Programmer * /usr/contributed Gatekeeper
