On Mon, 20 May 2002, Jeremy Howard wrote: > >sure all those prot_fill calls are really needed? SHUT_RD should dump any > >unread data from the socket anyway... > > > Not at all sure. I suspect they're not necessary. We added them because > we had to get our server up and running again ASAP which didn't leave > time to test what was necessary and what wasn't, so we added everything
That's what I thought. Well, I will add them if someone points out that they're really needed. Maybe I will get a server I can throw a massive load test sometime in the next two months, and that should help shaping up this issue. > we could think of. I agree that SHUT_RD ought to correctly flush the > receive buffer. The prot_flush()s are still necessary I think--IIRC we > added a few where they seemed to be missing. Yes, prot_flushs are probably a good idea. However, I don't recall needing to add any (I applied the functionality on your diffs by hand, line per line). Maybe they were there already for 2.1.4; If you notice any missing, please drop me a line and I'll add them. > Thanks for your hard work on this, Henrique. Sure, no problem. We all get a better Cyrus IMAPd in the end, and everybody is happy. That's why I love in this work. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
