Lawrence Greenfield wrote:
> 
>    Date:   Mon, 1 Oct 2001 11:00:22 +0200
>    From: Szymon Juraszczyk <[EMAIL PROTECTED]>
> 
>      I just changed
> 
>        sprintf 
>(messageToSend,"%s\n%s\n%s\n%s\n%s\n",class,instance,user,mailbox,message);
> 
>      to
> 
>        sprintf (messageToSend,"%s\n%s\n%s\n%s\n",class,instance,user,mailbox);
>        cnt = write(sock, messageToSend, strlen(messageToSend));
>        cnt += write(sock, message, strlen(message));
>        cnt += write(sock, &newline, 1);

This doesnt fix the buiffer overrun.

messageToSend is still 2K and can be overwritten

howabout

snprintf(messageToSend,sizeof(messageToSend) -1,"%s blah blah blha)


-- 
Simon

Reply via email to