Hi Štěpán, On Sun, Jul 11, 2010 at 09:45:17PM +0200, Štěpán Němec wrote: > > commit dbf7305dbde4737d73748ae31e724e722ef0ce34 > Author: Stephen Bach <[email protected]> > Date: Fri Jul 9 13:44:46 2010 -0400 > > For hideshow mode, don't hide all lines by default > --- > vimpulse-compatibility.el | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/vimpulse-compatibility.el b/vimpulse-compatibility.el > index c2c59f0..9d0adae 100644 > --- a/vimpulse-compatibility.el > +++ b/vimpulse-compatibility.el > @@ -294,7 +294,6 @@ (eval-after-load 'hideshow > (hs-toggle-hiding) > (hs-hide-level vimpulse-fold-level)) > (defun vimpulse-hs-setup () > - (hs-hide-all) > (define-key viper-vi-basic-map "za" 'vimpulse-za) > (define-key viper-vi-basic-map "zm" 'hs-hide-all) > (define-key viper-vi-basic-map "zr" 'hs-show-all) > > > Why? Isn't that what Vim does, when you turn folding on? (It would have > been nice to have the rationale in the commit message, providing there > is one).
Only in files which are explicitly setup for folding. > I don't use hs-minor-mode, but a possible reason for this change I can > think of is that it breaks existing Emacs user expectations, because the > mode hook triggers the hiding unconditionally. Is that it? Yes. If one wants to hide-all in every file, it's as easy as adding hs-hide-all to the same hook; anyone who's gone to the trouble of setting up hideshow should know how to do that. I think it's better if Vimpulse doesn't make a large assumption about how people use hideshow, an external package.
signature.asc
Description: Digital signature
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
