On Tue, 7 Apr 2026 17:36:53 GMT, Justin Lu <[email protected]> wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Enabled zone alias > > src/java.base/share/classes/java/text/SimpleDateFormat.java line 1305: > >> 1303: .getLocaleResources(Locale.ROOT) >> 1304: .getTimeZoneNames("metazone.dstoffset." + >> TimeZoneNameUtility.canonicalTZID(tzid).orElse(tzid)); >> 1305: boolean daylight = explicitDstOffset != null && > > I think it would be easier to understand it if we just broke it into a > conditional based on the existence of the _explicitDstOffset_ rather than > bundle it up in a single expression. Then if it exists, we can comment that > daylight is derived from it, otherwise fallback. The current logic applies > the `dstOffset != zoneOffset` fallback logic even if _explicitDstOffset_ > exists, which I'm not sure is needed.
Good point, and indeed fallback is not needed. Corrected as suggested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30594#discussion_r3047451289
