On Thu, 26 Mar 2026 11:34:15 GMT, serhiysachkov <[email protected]> wrote:
>> Update testng and junit tests to use diagnoseConfigurationIssue() method and
>> post processing
>
> serhiysachkov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8380990: fix merge junit conversion issue
test/jdk/java/lang/ProcessBuilder/ReaderWriterTest.java line 182:
> 180: System.out.println("Charset: " + cs);
> 181: } catch (UnsupportedCharsetException use) {
> 182: throw new TestAbortedException("Charset not supported: " +
> encoding);
@sormuras will be able to confirm, but I believe the blessed way of doing that
with JUnit would be to call something like:
Assumptions.assumeTrue(false, "Charset not supported: " + encoding);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30446#discussion_r2994241280
