[
https://issues.apache.org/jira/browse/HDFS-17970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109695#comment-18109695
]
ASF GitHub Bot commented on HDFS-17970:
---------------------------------------
hadoop-yetus commented on PR #8709:
URL: https://github.com/apache/hadoop/pull/8709#issuecomment-5469819233
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 19m 46s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 47m 54s | | trunk passed |
| +1 :green_heart: | compile | 1m 50s | | trunk passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | compile | 1m 49s | | trunk passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 1m 50s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 59s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 30s | | trunk passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javadoc | 1m 30s | | trunk passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 4m 23s | | trunk passed |
| +1 :green_heart: | shadedclient | 42m 50s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 24s | | the patch passed |
| +1 :green_heart: | compile | 1m 17s | | the patch passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 1m 17s | | the patch passed |
| +1 :green_heart: | compile | 1m 22s | | the patch passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 1m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 59s | | the patch passed with JDK
Ubuntu-21.0.12+8-1-24.04-Ubuntu |
| +1 :green_heart: | javadoc | 1m 3s | | the patch passed with JDK
Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 4m 5s | | the patch passed |
| +1 :green_heart: | shadedclient | 36m 36s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 264m 21s | | hadoop-hdfs in the patch
passed. |
| -1 :x: | asflicense | 0m 55s |
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8709/1/artifact/out/results-asflicense.txt)
| The patch generated 1 ASF License warnings. |
| | | 438m 6s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.55 ServerAPI=1.55 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8709/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8709 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux ae8fd63dc7b3 5.15.0-185-generic #195-Ubuntu SMP Fri Jun 19
17:11:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 2339461c0bdc3d30e3f3eb329c540eb3d7d414ff |
| Default Java | Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12+8-1-24.04-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20+8-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8709/1/testReport/ |
| Max. process+thread count | 2468 (vs. ulimit of 10000) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8709/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> EC checksum reconstruction should exclude the failed checksum target from
> source inputs
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-17970
> URL: https://issues.apache.org/jira/browse/HDFS-17970
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, ec, erasure-coding
> Affects Versions: 3.2.2, 3.5.0
> Environment: Apache Hadoop trunk base:
> 33237971fa49f7ba0a0f4e2790dfdd7b792e8acc
> Operating system: macOS 15.6
> Java: Eclipse Temurin 17.0.6
> Test environment: MiniDFSCluster
> Erasure coding policy: default RS-6-3 policy
> dfs.datanode.ec.reconstruction.validation=true
> The same source construction is present in the Hadoop 3.5.0 release and
> current upstream trunk.
> Reporter: Jay Zou
> Priority: Major
> Labels: pull-request-available
>
> h3. Problem
> When a child BLOCK_CHECKSUM request fails for an internal block while the
> block remains available for READ_BLOCK,
> BlockGroupNonStripedChecksumComputer#recalculateChecksum() marks the failed
> block index as a reconstruction target, but still passes the original
> blockIndices and datanodes arrays to StripedReconstructionInfo.
> The same internal block can therefore be selected as both a reconstruction
> target and a source. This violates the decoder input contract, which requires
> the input corresponding to an erased index to be null.
> h3. Impact
> With dfs.datanode.ec.reconstruction.validation=true, validation can be left
> with fewer than the required number of independent inputs and fail with:
> {code}
> No enough valid inputs are provided, not recoverable
> {code}
> The client may subsequently observe Unexpected EOF.
> When reconstruction validation is disabled, the decoder may read the target
> block to reconstruct the same target. The resulting checksum may happen to
> match, but the reconstruction input still violates the source/target
> disjointness invariant.
> h3. Reproduction
> A deterministic MiniDFSCluster test reproduces the problem as follows:
> # Enable dfs.datanode.ec.reconstruction.validation.
> # Create an erasure-coded file.
> # Obtain a normal BLOCK_GROUP_CHECKSUM response as the baseline.
> # Make one child BLOCK_CHECKSUM request fail by replacing only its child
> block token.
> # Keep the target DataNode and internal block online and readable.
> # Request BLOCK_GROUP_CHECKSUM again.
> The reconstruction READ_BLOCK path obtains a fresh read token, so the target
> remains readable after its child checksum request fails.
> Before the fix, both checksum-mode test instances fail through:
> {code}
> InvalidBlockTokenException
> -> recalculateChecksum()
> -> DecodingValidator.validate()
> -> No enough valid inputs are provided, not recoverable
> -> Unexpected EOF
> {code}
> h3. Expected behavior
> Checksum reconstruction should:
> * exclude every source position whose internal block index matches the target;
> * preserve block-index and DataNode pairing;
> * place distinct source indices before duplicate replicas;
> * retain non-target duplicate replicas as read fallbacks;
> * use the short-block-group-aware minimum source count;
> * fail with a contextual IOException when there are not enough distinct
> sources.
> h3. Related issues
> HDFS-15650 makes the EC checksum socket timeout configurable, and HDFS-17806
> discusses increasing that timeout. They can reduce how often reconstruction is
> triggered but do not enforce source/target disjointness.
> HDFS-15759 introduced DataNode EC reconstruction validation, and HDFS-15795
> fixed checksum handling after reconstruction exceptions. Neither excludes the
> failed checksum target from reconstruction sources.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
