[
https://issues.apache.org/jira/browse/HDFS-17956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101025#comment-18101025
]
ASF GitHub Bot commented on HDFS-17956:
---------------------------------------
pan3793 opened a new pull request, #8650:
URL: https://github.com/apache/hadoop/pull/8650
### Description of PR
Replace the unbounded do-while polling loop in `waitCheckpointDone` with
`GenericTestUtils.waitFor`, capping the wait at 60 seconds.
When a checkpoint never arrives, the loop sleeps indefinitely, hanging
the surefire fork until `forkedProcessTimeoutInSeconds` (900s) kills it.
The fork kill produces a generic "timeout in the fork" error with no
indication of which test hung. The bounded wait converts this into a
fast, clear `TimeoutException` naming the checkpoint txid that never
advanced.
### How was this patch tested?
Verified via GitHub Actions CI on a fork branch. Before the change, the
fork hangs 900s with no indication of the culprit. After the change,
`TestBackupNode` fails within 60s with:
```
TimeoutException: Timed out waiting for condition.
Error Message: Checkpoint txid did not advance above 1
```
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(HDFS-17956)?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by GLM 5.2"
where GLM 5.2 is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
Contains content generated by GLM 5.2
> Bound TestBackupNode.waitCheckpointDone with timeout
> ----------------------------------------------------
>
> Key: HDFS-17956
> URL: https://issues.apache.org/jira/browse/HDFS-17956
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Reporter: Cheng Pan
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
