[
https://issues.apache.org/jira/browse/HDFS-15491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100713#comment-18100713
]
ASF GitHub Bot commented on HDFS-15491:
---------------------------------------
joseluisll opened a new pull request, #8646:
URL: https://github.com/apache/hadoop/pull/8646
### Description of PR
[HDFS-15491](https://issues.apache.org/jira/browse/HDFS-15491) reports that
the `NumTransactionsBatchedInSync*` metrics documented for the JournalNode are
absent from JournalNode JMX, and proposes adding the metric to
`JournalMetrics.java`.
The metrics are not missing — they are documented in the wrong section.
The rows were added by
[HDFS-12320](https://issues.apache.org/jira/browse/HDFS-12320) (commit
`423ebcaf510`), which added the quantiles to `NameNodeMetrics.java` but
documented them under **JournalNode** in `Metrics.md`. That issue was filed
against the `metrics, namenode` components — the JournalNode was out of its
scope, and no JournalNode change is needed here either.
The rows are also wrong in detail: the quantiles are registered with
`valueName = "count"`, so the emitted names end in `...thPercentileCount`, not
`...thPercentileLatencyMicros`.
[HDFS-13674](https://issues.apache.org/jira/browse/HDFS-13674) later
documented the metric in the correct NameNodeActivity section but omitted the
`Num` prefix, and left the JournalNode rows in place. The metric is currently
documented twice, under two names, neither matching what is emitted.
#### Changes
1. Remove the 18 `NumTransactionsBatchedInSync*` rows from the JournalNode
section.
2. Correct the NameNodeActivity row to ``
`NumTransactionsBatchedInSync`*num*`s(50/75/90/95/99)thPercentileCount` ``.
Documentation only: 1 insertion, 19 deletions. No code or test changes.
### How was this patch tested?
Documentation-only change; verified by inspection.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation? — N/A
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)? — N/A
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files? — N/A
### AI Tooling
If an AI tool was used:
- [x] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [x] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
Contains content generated by Claude Code.
> Journal transactions batched in sync metrics are missing from Journal Node
> JMX
> --------------------------------------------------------------------------------
>
> Key: HDFS-15491
> URL: https://issues.apache.org/jira/browse/HDFS-15491
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, journal-node, qjm
> Affects Versions: 3.1.1
> Reporter: Mohit Saindane
> Assignee: Nishtha Shah
> Priority: Critical
> Labels: newbie, patch, pull-request-available
> Fix For: 3.1.1
>
> Attachments: JournalNode metrics issue.png
>
>
> I have enable the HA in HDP3.1.5 multinode cluster, I was trying to access
> the REST response given by Journal Node on http 8480 port, but as per [Apache
> Hadoop 3.1.1
> Documentation|[https://hadoop.apache.org/docs/r3.1.1/hadoop-project-dist/hadoop-common/Metrics.html#JournalNode]]
> I found that some of the Journal Node specific metrics are missing. (metrics
> like NumTransactionsBatchedInSync_(60,300,3600)_sNumOps and
> NumTransactionsBatchedInSync_Num_s_(50/75/90/95/99)_thPercentileLatencyMicros),
> So checked the _JournalMetrics.java_ code given in
> _hadoop-hdfs-3.1.1.3.1.5.0-152-sources.jar_ as well as __ [Hadoop Open Source
> Code|[https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java]]
> found that the following code is missing :
>
> @Metric("Journal transactions batched in sync")
> final MutableQuantiles[] numTransactionsBatchedInSync;
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
