[
https://issues.apache.org/jira/browse/HDFS-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076807#comment-18076807
]
ASF GitHub Bot commented on HDFS-17914:
---------------------------------------
lirui-apache opened a new pull request, #8463:
URL: https://github.com/apache/hadoop/pull/8463
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Avoid empty buffer read in DFSInputStream#actualGetFromOneDataNode by
terminating the loop once the buffer is filled.
### How was this patch tested?
Added new test
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Prevent DFSInputStream from issuing 0-byte reads
> ------------------------------------------------
>
> Key: HDFS-17914
> URL: https://issues.apache.org/jira/browse/HDFS-17914
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Reporter: Rui Li
> Priority: Major
>
> Currently, {{DFSInputStream#actualGetFromOneDataNode}} can issue an extra
> {{BlockReader#read}} after the buffer is completely filled. This extra read
> can cause a wasted slow-lane read into the bounce buffer for
> {{{}BlockReaderLocal{}}}.
> A possible fix is to terminate the loop once the requested slice is filled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
