[
https://issues.apache.org/jira/browse/HDFS-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18076130#comment-18076130
]
ASF GitHub Bot commented on HDFS-17912:
---------------------------------------
eubnara opened a new pull request, #8456:
URL: https://github.com/apache/hadoop/pull/8456
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
hadoop-httpfs.sh sourced httpfs-env.sh from HADOOP_CONF_DIR only, even
though HTTPFS_CONFIG is already honored for -Dhttpfs.config.dir in the same
script. Use ${HTTPFS_CONFIG:-${HADOOP_CONF_DIR}} so both paths agree. Backward
compatible.
See description on https://issues.apache.org/jira/browse/HDFS-17912, please.
### How was this patch tested?
Manually test on private cluster
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
> HttpFS: hadoop-httpfs.sh ignores HTTPFS_CONFIG when locating httpfs-env.sh
> --------------------------------------------------------------------------
>
> Key: HDFS-17912
> URL: https://issues.apache.org/jira/browse/HDFS-17912
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: httpfs
> Affects Versions: 3.3.6, 3.5.0, 3.4.3
> Reporter: YUBI LEE
> Priority: Major
>
> hadoop-httpfs.sh sources httpfs-env.sh from HADOOP_CONF_DIR only,
> even though HTTPFS_CONFIG is honored elsewhere in the same script
> (e.g. -Dhttpfs.config.dir).
> If you set HTTPFS_CONFIG to a separate directory, httpfs-site.xml is
> read from there but httpfs-env.sh is silently skipped, which is
> confusing.
> Fix: use ${HTTPFS_CONFIG:-${HADOOP_CONF_DIR}} for httpfs-env.sh too.
> Backward compatible since HTTPFS_CONFIG defaults to HADOOP_CONF_DIR.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
