[
https://issues.apache.org/jira/browse/HDFS-17865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073675#comment-18073675
]
ASF GitHub Bot commented on HDFS-17865:
---------------------------------------
kokonguyen191 commented on PR #8144:
URL: https://github.com/apache/hadoop/pull/8144#issuecomment-4250087748
@ZanderXu I think can keep both patches as is. This PR can complement the
changes in [HDFS-14276](https://issues.apache.org/jira/browse/HDFS-14276).
Reverting it will no longer block the edit log tailer but the background
metrics updater will run more frequently, consuming some extra CPU power.
Hi @ayushtkn, can you take a look at this PR if you're free? Thanks!
> Prevent updateNameDirSize() from blocking rollEditLog()
> -------------------------------------------------------
>
> Key: HDFS-17865
> URL: https://issues.apache.org/jira/browse/HDFS-17865
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Felix N
> Assignee: Felix N
> Priority: Minor
> Labels: pull-request-available
>
> updateNameDirSize() has only metrics functionality (i.e. not very critical)
> but has a fair bit of performance impact in one of the more critical methods
> (rollEditLog). It's better to either reduce the metrics update frequency or
> make it update asynchronously to avoid interference with rollEditLog().
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
