[
https://issues.apache.org/jira/browse/HDFS-17901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18068867#comment-18068867
]
ASF GitHub Bot commented on HDFS-17901:
---------------------------------------
CapMoon opened a new pull request, #8386:
URL: https://github.com/apache/hadoop/pull/8386
HDFS-17901. Fix getEligibleChildren not handling DatanodeInfo in
excludedNodes
### Description of PR
In `DFSNetworkTopology#getEligibleChildren()`, when iterating over
excludedNodes, the method only handles `DatanodeDescriptor` and
`DFSTopologyNodeImpl` types but misses the `DatanodeInfo` type. This causes
storageCount to be incorrectly calculated (overestimated), leading to
inconsistency with the parent method `chooseRandomWithStorageType()` and
potentially incorrect weighted random node selection.
> Fix DFSNetworkTopology#getEligibleChildren missing DatanodeInfo handling
> causing incorrect storageCount
> -------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17901
> URL: https://issues.apache.org/jira/browse/HDFS-17901
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 3.4.3
> Reporter: yue.wang
> Priority: Major
>
> In DFSNetworkTopology#getEligibleChildren(), when iterating over
> excludedNodes, the method only handles DatanodeDescriptor and
> DFSTopologyNodeImpl types but misses the DatanodeInfo type. This causes
> storageCount to be incorrectly calculated (overestimated), leading to
> inconsistency with the parent method chooseRandomWithStorageType() and
> potentially incorrect weighted random node selection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
