[ 
https://issues.apache.org/jira/browse/HDFS-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021982#comment-18021982
 ] 

ASF GitHub Bot commented on HDFS-17579:
---------------------------------------

github-actions[bot] commented on PR #6941:
URL: https://github.com/apache/hadoop/pull/6941#issuecomment-3321968918

   We're closing this stale PR because it has been open for 100 days with no 
activity. This isn't a judgement on the merit of the PR in any way. It's just a 
way of keeping the PR queue manageable.
   If you feel like this was a mistake, or you would like to continue working 
on it, please feel free to re-open it and ask for a committer to remove the 
stale tag and review again.
   Thanks all for your contribution.




> [DatanodeAdminDefaultMonitor] Better Comments Explaining Why Blocks Need 
> Reconstruction May Not Block Decommission/Maintenance
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17579
>                 URL: https://issues.apache.org/jira/browse/HDFS-17579
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: dfsadmin
>            Reporter: wuchang
>            Priority: Major
>              Labels: pull-request-available
>
> Below comments for explaining why blocks which need reconstruction may not 
> block decommission/maintenance is weird:
> {code:java}
>       // Even if the block is without sufficient redundancy,
>       // it might not block decommission/maintenance if it
>       // has sufficient redundancy.
>       if (dnAdmin.isSufficient(block, bc, num, isDecommission, 
> isMaintenance)) {
>         if (pruneReliableBlocks) {
>           it.remove(); {code}
> I checked the detailed code and get the reason that why blocks which need 
> reconstruction may not block decommission/maintenance, and give it a better 
> comment



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to