[
https://issues.apache.org/jira/browse/HDFS-17718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939915#comment-17939915
]
ASF GitHub Bot commented on HDFS-17718:
---------------------------------------
slfan1989 commented on code in PR #7563:
URL: https://github.com/apache/hadoop/pull/7563#discussion_r2022183487
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/util/TestByteArrayManager.java:
##########
@@ -391,7 +396,7 @@ static void sleepMs(long ms) {
Thread.sleep(ms);
} catch (InterruptedException e) {
e.printStackTrace();
- Assert.fail("Sleep is interrupted: " + e);
+ Assertions.fail("Sleep is interrupted: " + e);
Review Comment:
We should optimize the usage of `Assertions.fail` by importing it statically.
> Upgrade JUnit from 4 to 5 in hadoop-hdfs-client.
> ------------------------------------------------
>
> Key: HDFS-17718
> URL: https://issues.apache.org/jira/browse/HDFS-17718
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Shilun Fan
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
