[
https://issues.apache.org/jira/browse/HDFS-17636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889010#comment-17889010
]
ASF GitHub Bot commented on HDFS-17636:
---------------------------------------
GauthamBanasandra commented on code in PR #7096:
URL: https://github.com/apache/hadoop/pull/7096#discussion_r1798460525
##########
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/CMakeLists.txt:
##########
@@ -57,7 +57,7 @@ set(LIBHDFS_VERSION "0.0.0")
set_target_properties(hdfs PROPERTIES
SOVERSION ${LIBHDFS_VERSION})
-build_libhdfs_test(test_libhdfs_ops hdfs_static test_libhdfs_ops.c)
+build_libhdfs_test(test_libhdfs_ops hdfs_static test_libhdfs_ops.c
../libhdfs/hdfs.c)
Review Comment:
Yeah, I was testing something locally and I had to add this. I'll remove
this before merging.
> Don't add declspec for Windows
> ------------------------------
>
> Key: HDFS-17636
> URL: https://issues.apache.org/jira/browse/HDFS-17636
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs
> Affects Versions: 3.5.0
> Environment: Windows 10/11
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Blocker
> Labels: pull-request-available
>
> * Windows doesn't want the
> macro _JNI_IMPORT_OR_EXPORT_
> to be defined in the function
> definition. It fails to compile with
> the following error -
> "definition of dllimport function
> not allowed".
> * However, Linux needs it. Hence,
> we're going to add this macro
> based on the OS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
