[
https://issues.apache.org/jira/browse/HDFS-17461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836372#comment-17836372
]
ASF GitHub Bot commented on HDFS-17461:
---------------------------------------
ayushtkn commented on code in PR #6721:
URL: https://github.com/apache/hadoop/pull/6721#discussion_r1561813524
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PeerCache.java:
##########
@@ -155,7 +155,7 @@ public Peer get(DatanodeID dnId, boolean isDomain) {
private synchronized Peer getInternal(DatanodeID dnId, boolean isDomain) {
List<Value> sockStreamList = multimap.get(new Key(dnId, isDomain));
- if (sockStreamList == null) {
+ if (sockStreamList.isEmpty()) {
return null;
Review Comment:
We can just drop this if check itself, the below logic can safely handle an
empty list
> Fix spotbugs in PeerCache#getInternal
> -------------------------------------
>
> Key: HDFS-17461
> URL: https://issues.apache.org/jira/browse/HDFS-17461
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
>
> Fix spotbugs in PeerCache#getInternal
> Spotbugs warnings：
> https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6710/4/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
