Le 31/03/2026 à 12:04 AM, Nenad Merdanovic a écrit :

I think I covered everything suggested, function has been renamed to
is_immutable_header, I updated the docs referencing the lack of parser
validation and the max number of headers. I've also added the prefix
keyword that will allow set/add-headers-bin to only add those headers
matching the prefix. New patch attached.

Hi Nenad,

I merged your patch, but this morning, I've a doubt. You are using a log-format string for the headers argument. it seems a bit overkill. A sample expression is probably good enough. Especially because it is a bit hard to craft it by hand because of the varint encoding. Most of time, I guess a variable will be used. Then, you're requesting a base64 encoding. It seems a bit strange. There is no reason to force the argument to be encoded in base64. Especially because the result of req.hdrs_bin and res.hdrs_bin are not base64 encoded. And b64dec converter can still be used if necessary.

If you agree, I would like to change the actions to rely on a sample expression returning a varint encoded binary string. If you want to handle it, I'm ok too :)

Regards,
--
Christopher Faulet


Reply via email to