Hi, On Wed, Aug 07, 2024 at 11:55:59PM -0300, Lucas de Sena wrote: > When embedded, st fails with BadMatch error if the embedder's window has > non-default colormap/depth/visual. This commit fixes that by creating > st's window inside root and then reparent it into embedder. > > The reference window for dc.gc is also changed to match root's visuals. > > A similar commit had been made for dmenu[1]. > See this issue[2] on github for context.
With a fast review, this seems right to me. Regards,
