At 2025-12-16T19:31:31-0600, G. Branden Robinson wrote:
> I found the [commit] responsible for the [change].
> 
> I was able to revert it cleanly (i.e., no merge conflicts).

...but I won't be pushing that reversion without further discussion.

> You might be interested in what it was.
> 
> $ git show 3d249f79fd662e0e033ee1dc564f242b1a753e3c|cat
> commit 3d249f79fd662e0e033ee1dc564f242b1a753e3c
> Author: G. Branden Robinson <[email protected]>
> Date:   Mon Mar 17 01:19:54 2025 -0500
> 
>     [troff]: Fix Savannah #55799 (`-a` opt + `char`).
> 
>     * src/roff/troff/node.cpp (composite_node::ascii_print): When rendering
>       a composite node for approximate output, traverse into it and write
>       its nodes' representations in forward order.
> 
>     Fixes <https://savannah.gnu.org/bugs/?55799>.  Thanks to Dave Kemper for
>     the report.  Problem appears to date back to groff's birth.

Reverting this commit causes 3 automated test failures:

FAIL: src/roff/groff/tests/asciify-composite-nodes-correctly.sh
FAIL: src/roff/groff/tests/asciify-request-works.sh
FAIL: src/roff/groff/tests/composite-nodes-produce-approximate-output.sh

Regards,
Branden

Attachment: signature.asc
Description: PGP signature

Reply via email to