At 2023-09-01T12:47:58-0500, G. Branden Robinson wrote: > I'm happy with this and will start merging. Any tweaks I make will be > in a subsequent commit, unless merging it as-is breaks the > build/tests, in which case I'll let you know.
I'm letting you know. ============================================================================ Testsuite summary for GNU roff 1.23.0.383-1d845 ============================================================================ # TOTAL: 185 # PASS: 180 # SKIP: 1 # XFAIL: 2 # FAIL: 2 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to http://savannah.gnu.org/bugs/?group=groff ============================================================================ FAIL: src/devices/grotty/tests/osc8_works.sh FAIL: src/roff/groff/tests/some_escapes_accept_newline_delimiters.sh The latter is the one that actually concerns me more of the two. Instrumenting the failing cases, I get: $ ../src/roff/groff/tests/some_escapes_accept_newline_delimiters.sh checking that newline is accepted as delimiter to 'A' escape checking correct handling of newline delimiter to 'A' escape checking that newline is accepted as delimiter to 'b' escape checking correct handling of newline delimiter to 'b' escape checking that newline is accepted as delimiter to 'o' escape checking correct handling of newline delimiter to 'o' escape 0000000 C D 0000004 ...FAILED checking that newline is accepted as delimiter to 'w' escape checking correct handling of newline delimiter to 'w' escape checking that newline is accepted as delimiter to 'X' escape checking correct handling of newline delimiter to 'X' escape checking that newline is accepted as delimiter to 'Z' escape checking correct handling of newline delimiter to 'Z' escape 0000000 A D C 0000004 ...FAILED Here's what the test expects. # 7 spaces between C and D. printf "%s\n" "$output" \ | grep -Eqx '0000000 +A +\\b +B +\\b +C D +\\n *' || wail printf "%s\n" "$output" | grep -Eqx '0000000 +A +B +\\b +D +C +\\n *' \ || wail '\\b' means "backspace". These suggest to me that overstriking is not happening. This may be a matter of forcing overstriking on for these tests. How about the OSC 8 test failure? $ ../src/devices/grotty/tests/osc8_works.sh expect two diagnostic messages regarding ill-formed links ./grotty:<standard input>:15: warning: ending hyperlink when none was started ./grotty:<standard input>:17: warning: new hyperlink started without ending previous one; recovering testing for URI that corresponds to no character cells Hmm, it doesn't say what went wrong... Oh, woe is me--this test is from 2021 and still uses "set -e", not the newer "wail and fail" approach I've adopted. I'll see if I can improve these tests and get back to you. Regards, Branden
signature.asc
Description: PGP signature
