Salut Bertrand, Bertrand Garrigues wrote on Wed, Dec 19, 2018 at 01:10:07AM +0100:
> I've just pushed a fix on the build system as 'make doc' failed on > OpenIndiana. Now the build with default configure options, 'make > check', 'make doc' work as expected on Archlinux, OpenIndiana, Solaris > 11 and Debian testing. > > Does anyone sees an issue that demands a fix for the next release? If > no, then I'll make a rc5 for (hopefully) final checks before releasing > the 1.22.4. I think we are ready for rc5. I see no more problems on OpenBSD, Debian Jessie, Solaris 11, and Solaris 10. Even on Solaris 9, configure, make, make install and running groff work out of the box with only this "make check" failure: ======================================== GNU Troff 1.22.4: ./test-suite.log ======================================== # TOTAL: 3 # PASS: 2 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: contrib/mom/examples/tests-mom.sh ======================================= ./contrib/mom/examples/tests-mom.sh: !: not found ./contrib/mom/examples/tests-mom.sh: !: not found ./contrib/mom/examples/tests-mom.sh: !: not found ./contrib/mom/examples/tests-mom.sh: !: not found ./contrib/mom/examples/tests-mom.sh: !: not found ./contrib/mom/examples/tests-mom.sh: !: not found Checking number of pages of /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/con trib/mom/examples/letter.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories Error: expected 1 pages, found pages Checking number of pages of /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/con trib/mom/examples/mom-pdf.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories Error: expected 8 pages, found pages Checking number of pages of /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/con trib/mom/examples/mon_premier_doc.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories Error: expected 5 pages, found pages Checking number of pages of /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/con trib/mom/examples/sample_docs.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories Error: expected 12 pages, found pages Checking number of pages of /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/con trib/mom/examples/slide-demo.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories Error: expected 27 pages, found pages Checking number of pages of /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/con trib/mom/examples/typesetting.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories Error: expected 3 pages, found pages Checking if /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/contrib/mom/example s/typesetting.pdf has images pdfimages: cannot find/execute "pdfimages" in ISA subdirectories no images found Checking if /home/schwarze/groff-1.22.4.rc4p5.solaris9/build/contrib/mom/example s/slide-demo.pdf has images pdfimages: cannot find/execute "pdfimages" in ISA subdirectories no images found Looks like the ancient Bourne Shell lacks a feature. $ if ! true; then echo what; else echo OK; fi !: not found OK >From https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_02 i conclude this is POSIX syntax, so i don't think it needs to be fixed. If i change the line as follows: if test -f $examplesdir/$k; then : ; else then the six "not found" messages go away, but the remaining errors persist, in particular the "cannot find/execute" errors. $ which pdfinfo /opt/csw/bin/pdfinfo $ which pdfimages /opt/csw/bin/pdfimages $ strings /opt/csw/bin/pdfinfo | grep ISA %s: cannot find the ISA list %s: cannot find/execute "%s" in ISA subdirectories $ pdfinfo letter.pdf pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories $ echo $? 1 I have no idea why pdfinfo(1) does not work or what ISA subdirectories are. What might be a bit more serious is that most of the PDF files built on Solaris 9 are actually empty: 17507 Jan 10 2018 ./contrib/mom/examples/penguin.pdf 118683 Dec 19 02:16 ./build/contrib/pdfmark/pdfmark.pdf 0 Dec 19 02:16 ./build/contrib/mom/examples/slide-demo.pdf 0 Dec 19 02:16 ./build/contrib/mom/examples/typesetting.pdf 0 Dec 19 02:16 ./build/contrib/mom/examples/mon_premier_doc.pdf 0 Dec 19 02:15 ./build/contrib/mom/examples/mom-pdf.pdf 0 Dec 19 02:16 ./build/contrib/mom/examples/sample_docs.pdf 0 Dec 19 02:15 ./build/contrib/mom/examples/letter.pdf 0 Dec 19 02:12 ./build/doc/automake.pdf 17507 Dec 19 02:15 ./build/penguin.pdf And indeed, looking at the build log: GROFF contrib/mom/examples/slide-demo.pdf Constant name 'HASH(0x53cec)' has invalid characters at /home/schwarze/groff-1.2 2.4.rc4p5.solaris9/build/gropdf line 33 BEGIN failed--compilation aborted at /home/schwarze/groff-1.22.4.rc4p5.solaris9/ build/gropdf line 33. So, now we know that gropdf(1) doesn't work with Perl 5.6.1 (sic!). Isn't that great? I'd say, lets call it a day and move on. Yes, there are still people running Solaris 9, but i start feeling like they shouldn't. Yours, Ingo
