At 2018-12-17T20:56:53-0500, Peter Schaffter wrote: > Branden -- > > I'd like the bibliography/refer fix to mom to be in the upcoming > release. On my end, regression tests check out and the sample docs > build fine. Okay to push, or will that mess things up?
Bertrand is the person to ask, as he's the release manager. You've got a +1 from me on general principle, but I will understand if Bertrand wants to defer if he's already run a build through a whole of systems (like Nelson Beebe's huge build farm). I'm attaching the diff between the tree and the om.tmac from your 2.4 tar file. I'm afraid I can't really code-review it as you're a more sophisticated macro programmer than I am. (For example, I recognize the "transparent line indicator" escape but I have no idea what your use case is.) Regards, Branden
--- /home/branden/src/GIT/groff/contrib/mom/om.tmac 2018-11-26 23:02:38.427980563 -0500
+++ ./mom-2.4/om.tmac 2018-12-17 19:56:55.000000000 -0500
@@ -9176,7 +9176,7 @@
\#
.MAC HDRFTR_CENTER END
. nr #USER_DEF_HDRFTR_CENTER 1
-. if '\\$0'FOOTER_CENTER' \{\
+. if '\\$0'HEADER_CENTER' \{\
. ds $HDRFTR_CENTER_OLD \\*[$HDRFTR_CENTER]
. ds $HDRFTR_CENTER_NEW \\$1
. \}
@@ -12628,7 +12628,7 @@
. el .sp \\n[#DOC_LEAD]u+\\n[#Q_LEAD_DIFF]u
. \}
. el \{\
-. sp \\n[#DOC_LEAD]u
+. if '\\*[$QUOTE_TYPE]'Q' .sp \\n[#DOC_LEAD]u
. if \\n[@TOP] .rs
. \}
. ie \\n[#Q_LEAD_REAL] \
@@ -14938,7 +14938,7 @@
. ps \\n[#\\*[EN-OR-BIB]_PS]u\\*[$\\*[EN-OR-BIB]_STRING_SIZE_CHANGE]
. vs \\n[#\\*[EN-OR-BIB]_LEAD]u
. \}
-. substring $\\*[$EN-OR-BIB]_STRING_QUAD 0 0
+. substring $\\*[EN-OR-BIB]_STRING_QUAD 0 0
. if '\\*[$\\*[EN-OR-BIB]_STRING_QUAD]'L' .LEFT
. if '\\*[$\\*[EN-OR-BIB]_STRING_QUAD]'C' .CENTER
. if '\\*[$\\*[EN-OR-BIB]_STRING_QUAD]'R' .RIGHT
@@ -15956,13 +15956,23 @@
. \}
. ds pre-list-quad \\*[$QUAD_VALUE]
. substring pre-list-quad 0 0
-. if !'\\n[.z]'LIST*DIV' \{\
-. if '\\*[pre-list-quad]'C' .nr #LIST_CENTER 1
-. if '\\*[pre-list-quad]'R' .nr #LIST_RIGHT 1
-. nr #PRE_LIST_QUAD \\n[.j]
-. di LIST*DIV
-\!. nr #IN_LIST 1
-. ad l
+. if '\\*[pre-list-quad]'C' \{\
+. if !'\\n[.z]'LIST*DIV' \{\
+. nr #PRE_LIST_QUAD \\n[.j]
+. nr #LIST_CENTER 1
+. if !'\\n[.z]'LIST*DIV' .di LIST*DIV
+\!. nr #IN_LIST 1
+. ad l
+. \}
+. \}
+. if '\\*[pre-list-quad]'R' \{\
+. if !'\\n[.z]'LIST*DIV' \{\
+. nr #PRE_LIST_QUAD \\n[.j]
+. nr #LIST_RIGHT 1
+. if !'\\n[.z]'LIST*DIV' .di LIST*DIV
+\!. nr #IN_LIST 1
+. ad l
+. \}
. \}
. ie \\n[#NUM_ARGS]=0 \{\
. nr #ARGS_TO_LIST 1 \" So default behaves as if LIST BULLET
signature.asc
Description: PGP signature
