Salut Bertrand,
i just finished redoing the tests. I'm not sure how much they tell
us about the upcoming release: i built the release tarballs that i
now tested myself, starting with the process described in INSTALL.REPO.
I also had a look at the changes you committed and didn't spot anything
that seemed suspicious to me. But i admit i didn't study the changes
to m4/groff.m4; that kind of code always feels horrific to me.
OpenBSD-current:
----------------
Build, install, and the mandoc test suite still work, i see no regressions.
The groff test suite now works, too:
$ make check
make check-am
make
make all-am
make check-TESTS
PASS: contrib/gdiffmk/tests/gdiffmk_tests.sh
make all-am
============================================================================
Testsuite summary for GNU Troff 1.22.4
============================================================================
# TOTAL: 1
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
Debian Jessie:
--------------
Everything worked for rc4, everything still works, i see no regressions.
============================================================================
Testsuite summary for GNU Troff 1.22.4
============================================================================
# TOTAL: 3
# PASS: 3
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================
Solaris 11:
-----------
It still builds, installs, and runs.
The URW fonts are now found; change in the build log:
-checking whether URW fonts in pfb format are available...
-grep: illegal option -- A
-Usage: grep [-c|-l|-q] -bhinsvw pattern file . . .
-no
+checking whether URW fonts in pfb format are available...
+found in /opt/csw/share/ghostscript/fonts
[...]
- URW fonts for pdf : no
+ URW fonts for pdf : yes
The hypot() problem persists.
export groff_cv_decl_needed_hypot=no
is still needed before ../configure or the build fails as reported.
Even with that adjustment, the test suite still fails:
PASS: contrib/gdiffmk/tests/gdiffmk_tests.sh
FAIL: contrib/hdtbl/examples/test-hdtbl.sh
FAIL: contrib/mom/examples/tests-mom.sh
============================================================================
Testsuite summary for GNU Troff 1.22.4
============================================================================
# TOTAL: 3
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 2
# XPASS: 0
# ERROR: 0
FAIL: contrib/hdtbl/examples/test-hdtbl.sh
==========================================
Checking
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/hdtbl/examples/fonts_n.ps
Error: expected 38 pages, found 1 pages
Checking
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/hdtbl/examples/fonts_x.ps
Error: expected 38 pages, found 1 pages
FAIL: contrib/mom/examples/tests-mom.sh
=======================================
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/letter.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/mom-pdf.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/mon_premier_doc.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/sample_docs.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/slide-demo.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/typesetting.pdf
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't read xref table
Error: expected 3 pages, found pages
Checking if
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/typesetting.pdf
has images
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't read xref table
no images found
Checking if
/home/schwarze/groff-1.22.4.rc4p0.solaris11/build/contrib/mom/examples/slide-demo.pdf
has images
These failures made me curious, and i found this in the build log:
GROFF doc/webpage.ps
GROFF doc/grnexmpl.ps
GROFF doc/automake.pdf
troff: ../doc/automake.mom:56: can't transparently output node at top level
GEN contrib/hdtbl/examples/fonts_n.roff
GEN contrib/hdtbl/examples/fonts_x.roff
GROFF contrib/hdtbl/examples/chess_board.ps
GROFF contrib/hdtbl/examples/color_boxes.ps
GROFF contrib/hdtbl/examples/color_nested_tables.ps
GROFF contrib/hdtbl/examples/color_table_cells.ps
GROFF contrib/hdtbl/examples/color_transitions.ps
GROFF contrib/hdtbl/examples/col_rowspan_colors.ps
GROFF contrib/hdtbl/examples/fonts_n.ps
fonts_n.roff: listing fonts in ../font/devps
troff: contrib/hdtbl/examples/fonts_n.roff:143: name expected (got '\{')
fonts_n.roff: listing font ''...
troff: contrib/hdtbl/examples/fonts_n.roff:143: warning: can't find font '='
/usr/bin/ggrep: ../font/devps/: Is a directory
GROFF contrib/hdtbl/examples/fonts_x.ps
fonts_x.roff: listing fonts in ../font/devps
troff: contrib/hdtbl/examples/fonts_x.roff:154: name expected (got '\{')
fonts_x.roff: listing font ''...
troff: contrib/hdtbl/examples/fonts_x.roff:154: warning: can't find font '='
/usr/bin/ggrep: ../font/devps/: Is a directory
GROFF contrib/hdtbl/examples/mixed_pickles.ps
GROFF contrib/hdtbl/examples/rainbow.ps
GROFF contrib/hdtbl/examples/short_reference.ps
cp ../contrib/mom/examples/penguin.ps penguin.ps
cp ../contrib/mom/examples/penguin.pdf penguin.pdf
GROFF contrib/mom/examples/letter.pdf
troff: ../contrib/mom/examples/letter.mom:12: can't transparently output node
at top level
GROFF contrib/mom/examples/mom-pdf.pdf
These messages look suspicious in particular:
name expected (got '\{')
fonts_n.roff: listing font ''...
can't find font '='
/usr/bin/ggrep: ../font/devps/: Is a directory
Line 143 in fonts_n.roff is ".fontdump all", so that does not tell us
much. Reading the macro definition, i suspect that the string \\*[*$1]
in the line "if !F \\*[*$1] \{\" is empty. That suspicion is consistent
with the output "listing font ''..." which comes from
. tm \\*[fonts_n]: listing font '\\*[*$1]'...
a bit later.
Oh. I think i see (part of?) the problem:
> sh -c 'echo -n .ds'
-n .ds
On Solaris, no matter whether 11, 10, or 9, echo(1) in the default shell
conforms strictly to POSIX and, quoting
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html
"Implementations shall not support any options."
Not even -n. "echo -n" prints "-n" to stdout, followed by a newline.
Needless to say fonts_*.roff doesn't like that.
But even manually changing 'echo -n .ds' to 'echo .ds', i still see
unchanged error messages on Solaris 11. Still unsure what is going
on.
Solaris 10:
-----------
It still builds, installs, and runs.
The URW fonts are now found; change in the build log:
-checking whether URW fonts in pfb format are available...
-grep: illegal option -- A
-Usage: grep -hblcnsviw pattern file . . .
-no
+checking whether URW fonts in pfb format are available...
+found in /opt/csw/share/ghostscript/fonts
[...]
- URW fonts for pdf : no
+ URW fonts for pdf : yes
The test suite still fails:
> less test-suite.log
========================================
GNU Troff 1.22.4: ./test-suite.log
========================================
# TOTAL: 3
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 2
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: contrib/hdtbl/examples/test-hdtbl.sh
==========================================
Checking
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/hdtbl/examples/fonts_n.ps
Error: expected 38 pages, found 1 pages
Checking
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/hdtbl/examples/fonts_x.ps
Error: expected 38 pages, found 1 pages
FAIL: contrib/mom/examples/tests-mom.sh
=======================================
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/letter.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/mom-pdf.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/mon_premier_doc.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/sample_docs.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/slide-demo.pdf
Checking number of pages of
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/typesetting.pdf
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't read xref table
Error: expected 3 pages, found pages
Checking if
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/typesetting.pdf
has images
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't find trailer dictionary
Syntax Error: Couldn't read xref table
no images found
Checking if
/home/schwarze/groff-1.22.4.rc4p0.solaris10/build/contrib/mom/examples/slide-demo.pdf
has images
Solaris 9:
----------
It still builds and runs.
"make install" still dies from "for f in ; do", but you said we
do not need to worry about that.
The test suite still fails:
PASS: contrib/gdiffmk/tests/gdiffmk_tests.sh
FAIL: contrib/hdtbl/examples/test-hdtbl.sh
FAIL: contrib/mom/examples/tests-mom.sh
============================================================================
Testsuite summary for GNU Troff 1.22.4
============================================================================
# TOTAL: 3
# PASS: 1
# SKIP: 0
# XFAIL: 0
# FAIL: 2
# XPASS: 0
# ERROR: 0
============================================================================
FAIL: contrib/hdtbl/examples/test-hdtbl.sh
==========================================
Checking /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/contrib/hdtbl/examples
/fonts_n.ps
Error: expected 38 pages, found 1 pages
Checking /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/contrib/hdtbl/examples
/fonts_x.ps
Error: expected 38 pages, found 1 pages
FAIL: contrib/mom/examples/tests-mom.sh
=======================================
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
./contrib/mom/examples/tests-mom.sh: !: not found
Checking number of pages of /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/con
trib/mom/examples/letter.pdf
pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories
Error: expected 1 pages, found pages
Checking number of pages of /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/con
trib/mom/examples/mom-pdf.pdf
pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories
Error: expected 8 pages, found pages
Checking number of pages of /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/con
trib/mom/examples/mon_premier_doc.pdf
pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories
Error: expected 5 pages, found pages
Checking number of pages of /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/con
trib/mom/examples/sample_docs.pdf
pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories
Error: expected 12 pages, found pages
Checking number of pages of /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/con
trib/mom/examples/slide-demo.pdf
pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories
Error: expected 27 pages, found pages
Checking number of pages of /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/con
trib/mom/examples/typesetting.pdf
pdfinfo: cannot find/execute "pdfinfo" in ISA subdirectories
Error: expected 3 pages, found pages
Checking if /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/contrib/mom/example
s/typesetting.pdf has images
pdfimages: cannot find/execute "pdfimages" in ISA subdirectories
no images found
Checking if /home/schwarze/groff-1.22.4.rc4p0.solaris9/build/contrib/mom/example
s/slide-demo.pdf has images
pdfimages: cannot find/execute "pdfimages" in ISA subdirectories
Bertrand Garrigues wrote on Wed, Dec 05, 2018 at 01:16:18AM +0100:
> On Mon, Dec 03 2018 at 01:48:19 AM, Bertrand Garrigues wrote:
>> On Sat, Dec 01 2018 at 04:44:45 PM, Ingo Schwarze <schwa...@usta.de> wrote:
>>> So it appears you are unconditionally testing for optional features
>>> in the test suite.
>> Yes, I will work on Colin's suggestion wo exit with 77 in order to yield
>> a 'skip' result if the test can't be done due to missing fonts or
>> programs.
> I've pushed a fix for both hdtbl and mom example tests, could you please
> have a look?
>
> - test-hdtbl.sh: skip if 'gs' is not available.
>From the test on OpenBSD, that seems to work.
> - test-mom.sh: skip if URW are not available.
>From the test on OpenBSD, that seems to work, too.
> - I've also fixed the non-portable 'grep' command in GROFF_URW_FONTS.
>From the test on Solaris 11 and 10, that seems to work, too.
Yours,
Ingo
