Re: [Groff] Strange error messages from Groff 1.22.3

[Eli Zaretskii]

> Date: Thu, 20 Nov 2014 19:47:19 +0100 (CET)
> Cc: groff@gnu.org
> From: Werner LEMBERG <w...@gnu.org>
> 
> >> Sorry for the delayed answer.  Your patch looks fine, and I'm going
> >> to apply it soon.  Thanks a lot.
> > 
> > Great, thanks.  Now I can publish the binary with that patch and
> > claim that it was accepted upstream.
> 
> Now committed, with minor fixes.

Out of curiosity, why did you prefer this:

  +#if defined(__MSDOS__) || (defined(_WIN32) && !defined(__CYGWIN__))
  +void normalize_for_lf (string &fn)
  +{
  +  int fnlen = fn.length();
  +  for (int i = 0; i < fnlen; i++) {
  +    if (fn[i] == '\\')
  +      fn[i] = '/';
  +  }
  +}
  +#else
  +void normalize_for_lf (string &)
  +{
  +}
  +#endif

to my original change:

  +void normalize_for_lf (string &fn)
  +{
  +#if defined(__MSDOS__) || (defined(_WIN32) && !defined(__CYGWIN__))
  +  int fnlen = fn.length();
  +  for (int i = 0; i < fnlen; i++)
  +    {
  +      if (fn[i] == '\\')
  +       fn[i] = '/';
  +    }
  +#endif
  +}