> I've identified a potential buffer overrun in the above file; [...]
Thanks for catching this.
> Okay to commit?
Please go on.
> I believe I've matched the existing style of code layout, (which
> isn't entirely to my personal taste), but is the comment style
> acceptable? (I've annotated my changes considerably more
> comprehensively than the original).
I don't really mind, since it isn't consistent in the groff source.
However, as far as I can see, you are adding *another* style, and I
wonder whether there is a specific reason... Personally, I prefer
`//' due to its uniform look.
> +static
> +/**********
This I don't like. Please move the `static' keyword below the
comment.
> + * Returns (+ve) number of input characters stored into caller's
What is `+ve'?
Werner
