[ 
https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182784#comment-13182784
 ] 

Lewis John McGibbney commented on GORA-66:
------------------------------------------

Having written that then re-reading it I'm not entirely sure this is correct.

{bq}  As far as I can tell the end key in a query should be inclusive, but the 
test treats as exclusive. {bq}

The patch treats the end key as exclusive now rather than inclusive before is 
this correct? HBase treats as exclusive, we need to revert this part of the 
patch... Yes?
                
> testDeleteByQueryFields seems incorrect
> ---------------------------------------
>
>                 Key: GORA-66
>                 URL: https://issues.apache.org/jira/browse/GORA-66
>             Project: Gora
>          Issue Type: Bug
>            Reporter: Keith Turner
>         Attachments: GORA-66-1.patch
>
>
> While writing the Accumulo backend I have been trying to run some of the 
> existing test against it.  It seems that the test 
> DataStoreTestUtil.testDeleteByQueryFields() has two problems.
>  * The test does not flush the store after calling deleteByQuery().  This is 
> needed for accumulo since deletes are just inserts and must be flushed.
>  * The test expects the last key in a range that was deleted to be present.  
> As far as I can tell the end key in a query should be inclusive, but the test 
> treats as exclusive.
> I will submit a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to