Hi Ioannis, This is excellent, I've built locally and can confirm your commit solves the tests in question.
There are still 2 failing tests within this module [1], namely testCountQuery and testWordCount. These look more like a bug or typo somewhere in the code. I've not had much time to look into them yet. What's promising is that, again, both stack traces are identical :0) I've kicked off a build on Jenkins to run through after your commit so we will see if this has positive implications elsewhere... fingers crossed. https://builds.apache.org/job/gora-trunk/lastBuild/org.apache.gora$gora-core/testReport/junit/org.apache.gora.avro.mapreduce/TestDataFileAvroStoreMapReduce/testCountQuery/ On Wed, Dec 14, 2011 at 5:47 PM, Ioannis Canellos <[email protected]> wrote: > Ok, it does work. The trick is to configure the maven-surefire-plugin to run > using forkMode always. I committed it. > > On 14 Δεκ 2011, at 6:48 μ.μ., Ioannis Canellos wrote: > >> Hi, >> >> I think that most of the failures around this one, do not occur when we run >> a single test. >> This makes me think that one tests break the others. I have been trying to >> make the tests run isolated and I think I have made some progress here. I >> will probably commit this later today once I make sure it works fine. >> >> -- >> Ioannis Canellos >> >> On 13 Δεκ 2011, at 11:14 μ.μ., Lewis John Mcgibbney wrote: >> >>> Hi, >>> >>> Having a look at failing tests in gora-core module here. In particular >>> the following stack trace [1] which occurs for 5 tests in all. I >>> thought I had begun to solve it earlier but unfortunately I was wrong. >>> >>> I think it is the code below, taken from IOUtils which is which is >>> invoking the exception. I've added the important line numbers. For >>> clarity the stack trace notes that the NPE is caught at line 116. >>> >>> 107 /** Serializes the object to the given dataoutput using >>> * available Hadoop serializations >>> * @throws IOException */ >>> public static<T> void serialize(Configuration conf, DataOutput out >>> , T obj, Class<T> objClass) throws IOException { >>> >>> if(serializationFactory == null) { >>> serializationFactory = new SerializationFactory(getOrCreateConf(conf)); >>> } >>> 116 Serializer<T> serializer = >>> serializationFactory.getSerializer(objClass); >>> >>> ByteBufferOutputStream os = new ByteBufferOutputStream(); >>> try { >>> serializer.open(os); >>> 121 serializer.serialize(obj); >>> >>> >>> >>> [1] >>> https://builds.apache.org/job/gora-trunk/org.apache.gora$gora-core/67/testReport/org.apache.gora.mapreduce/TestPersistentSerialization/testSerdeEmployee/ >>> >>> >>> >>> -- >>> Lewis >> > -- Lewis
