I have published this
module: https://pkg.go.dev/github.com/keep94/sqroot/v2 for analysing square
roots and cube roots. The module works, but it is easy to write code that
will run forever. For example in v2:
// Print the position of the last 7 in the square root of 2. Oops, the
square root of 2 goes
// goes forever.
fmt.Println(sqroot.FindLast(sqroot.Sqrt(2), []int{7}))
// This code snippet runs in a finite amount of time as it prints the
position of the
// last 7 within the first 100 digits of the square root of 2.
fmt.Println(sqroot.FindLast(sqroot.Sqrt(2).WithSignificant(100), []int{7}))
v3, which hasn't been published makes it so that most code that would run
forever won't compile. It does this by introducing new types:
FiniteSequence which extends Sequence and FiniteNumber which extends
Number. In v3, sqroot.Sqrt() returns a Number since square roots can have
either a finite or infinite number of digits, but
sqroot.Sqrot(2).WithSignificant(100) returns a FiniteNumber because it can
have no more than 100 digits. In v3, sqroot.FindLast() takes a
FiniteSequence as a parameter, which is how
fmt.Println(sqroot.FindLast(sqroot.Sqrt(2), []int{7})) won't compile in v3.
The safety that v3 adds is great, but it comes at a cost. In v2, Number is
a concrete type. Its methods have examples in the documentation. But in v3,
Number has to be an interface because FiniteNumber has to extend Number and
Go does not support inheritance of concrete types. With Number as an
interface, all the examples for the Number methods disappear from the
documentation.
Also v3 adds some extra complexity with its diamond inheritance tree.
FiniteSequence and Number extend Sequence, and FiniteNumber extends Number
and FiniteSequence.
So I am wondering whether or not to publish v3. v3 is definitely harder to
misuse than v2, but v3 can't have all the code examples that v2 has because
Number is an interface in v3 not a concrete type.
So I am wondering what the community thinks is best in this situation.
--
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/golang-nuts/9185e296-e912-41ca-bfa7-c722efbe6f7en%40googlegroups.com.
