Our resident historian Jakob found that this isn't the first time we are running into ntfs deduplication issues, that already happened back in 2015 and might have relevant context around the question of "what's the expected behaviour for go std lib here": Go bug (resolved in 2017): https://github.com/golang/go/issues/10935 On Thursday, 21 September 2023 at 23:44:59 UTC+2 Ian Lance Taylor wrote:
> [ + Quin Muntal ] > > On Thu, Sep 21, 2023 at 10:34 AM Simon Frei <[email protected]> wrote: > > > > Hi, > > > > We got a report in syncthing that some files fail to sync on an ntfs > filesystem with deduplication enabled after upgrading the app: > https://github.com/syncthing/syncthing/issues/9120 > > The only change relevant to filesystem handling there was going from > go1.20 to go1.21. Debug logging shows that `IsRegular` returns false on > `LStat` result of this file, while this is a regular (though possibly > deduplicated) file so should be true and was true before. > > > > This change in go 1.21 seems like it's related, as it deals with reparse > points: > > > https://github.com/golang/go/commit/3e44b7d07a7b3c6233eb1bf4cf3cb00a0b85adec > > And so does ntfs deduplication according to this doc: > > > https://learn.microsoft.com/en-us/windows-server/storage/data-deduplication/understand > > > > Now my question is if this was an intentional change, or if this is a > regression and should be filed as a bug. The commit message suggest it > might more likely be a regression, as it seems focused on performance and > mentions symlinks being rare, so I doubt ntfs deduplication was on the > radar. > > > > Any comments about this, specifically if you feel like this might be a > regression/should be filed as a bug. I haven't tried to repro, don't have a > windows ntfs setup handy, but the issue seems clear enough to start reason > about it. > > > > Cheers, > > Simon > > > > -- > > You received this message because you are subscribed to the Google > Groups "golang-nuts" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/golang-nuts/c7b9a889-b659-4022-a5f1-439bde7e7b8fn%40googlegroups.com > . > -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/1fb5b5a5-db97-4ff8-a3b1-05b81f724b01n%40googlegroups.com.
