Hi Sytse, Thanks for your quick reply and helpful information! I think I fixed the issue, and I submitted a merge request here https://gitlab.com/gitlab-org/gitlab_git/merge_requests/16
Thanks, Tim On Saturday, January 10, 2015 at 1:49:15 PM UTC-6, sytse wrote: > > Hi Tim, > > Thanks for diving into this. The command probably refers to > https://gitlab.com/gitlab-org/gitlab_git > > Specifically to this method > > https://gitlab.com/gitlab-org/gitlab_git/blob/master/lib/gitlab_git/blame.rb#L5 > > > Best regards, > Sytse Sijbrandij > CEO GitLab B.V. > > > On Sat, Jan 10, 2015 at 11:06 AM, Tim Ringenbach > <[email protected] <javascript:>> wrote: > > Thanks, I guess. I was hoping for something more specific than "check > the > > source code", otherwise I wouldn't have bothered to ask. > > > > I checked the source code, but I don't really know ruby. > > > > I found "app/controllers/projects/blame_controller.rb" which does > "@blame = > > Gitlab::Git::Blame.new(project.repository, @commit.id, @path)" > > > > My best guess is that line is somehow wrong. > > > > I can't seem to find what Gitlab::Git::Blame.new refers to. I tried a > few > > 'git grep -i Blame' and I tried to use ctags, but none of the "new" > > functions it found seem to be the right one. I guess it must be a > library > > outside the scope of what I'm grepping, but that seems odd since it > starts > > with Gitlab and I'm grepping in 'gitlab-development-kit/gitlab'. > > > > I did find a bug that I think explains the problem: > > https://gitlab.com/gitlab-org/gitlab-ce/issues/866 > > > > And that does seem to be what's happening, if I go to: > > > http://localhost:3000/gitlab-org/gitlab-test/blame/feature/files/ruby/regex.rb > > > And > > > http://localhost:3000/gitlab-org/gitlab-test/blame/master/files/ruby/regex.rb > > > > The blame column is the same, and matches the history for master. > "feature" > > for that file only shows a single commit, but the blame view is showing > > multiple revisions, which link to commits that aren't actually present > in > > the feature branch. > > > > So anyway, some help finding out the code would be nice. > > > > Thanks, > > Tim > > > > > > > > > > On Tuesday, January 6, 2015 at 2:22:38 PM UTC-6, sytse wrote: > >> > >> Hi Tim, > >> > >> I recommend you check the source code to see what it is calling. > >> > >> Best regards, > >> Sytse Sijbrandij > >> CEO GitLab B.V. > >> > >> > >> On Tue, Jan 6, 2015 at 9:45 AM, Tim Ringenbach <[email protected]> > >> wrote: > >> > I'm running gitlab 7.4.3. I noticed that for a particular file (that > I > >> > can't > >> > share publicly) that the Blame view is wrong, and does not match what > >> > 'git > >> > blame' on the cli shows for the same file. > >> > > >> > I don't see anything being fixed with blame in the changelog, so I'm > >> > assuming it's a bug that still exists. > >> > > >> > What would I do to track this down? Is there a way to see what > commands > >> > gitlab is running to get this info? > >> > > >> > Thanks, > >> > Tim > >> > > >> > -- > >> > You received this message because you are subscribed to the Google > >> > Groups > >> > "GitLab" group. > >> > To unsubscribe from this group and stop receiving emails from it, > send > >> > an > >> > email to [email protected]. > >> > To view this discussion on the web visit > >> > > >> > > https://groups.google.com/d/msgid/gitlabhq/4c6f3b09-eccf-4b67-a94e-558300dab896%40googlegroups.com. > > > >> > For more options, visit https://groups.google.com/d/optout. > > > > -- > > You received this message because you are subscribed to the Google > Groups > > "GitLab" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to [email protected] <javascript:>. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/gitlabhq/99daf1de-9786-4d94-9b81-58226144af76%40googlegroups.com. > > > > > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GitLab" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/gitlabhq/17d12647-0279-43c4-8052-246eaacae904%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
