bryancall commented on code in PR #12886:
URL: https://github.com/apache/trafficserver/pull/12886#discussion_r2805619955
##########
tests/gold_tests/post/post-early-return.test.py:
##########
@@ -83,23 +83,23 @@
# The third case has an explicit multi-second sleep which ensures the early
response path is exercised
test_run = Test.AddTestRun("http1.1 Post with small body early return")
test_run.Processes.Default.StartBefore(Test.Processes.ts)
-test_run.Processes.Default.StartBefore(server1)
+test_run.Processes.Default.StartBefore(server1,
ready=When.PortOpen(Test.Variables.upstream_port1))
Review Comment:
Great suggestion, thanks. I updated this to set readiness on the upstream
process objects directly (`serverN.Ready = When.PortOpen(...)`) and switched
the call sites back to plain `StartBefore(serverN)`.
##########
tests/gold_tests/thread_config/thread_config.test.py:
##########
@@ -39,7 +39,7 @@
TS_ROOT = ts.Env['TS_ROOT']
tr.Processes.Default.Command = f'{sys.executable} check_threads.py -p
{TS_ROOT} -e 1 -a 0 -t 1 -c 1'
tr.Processes.Default.ReturnCode = 0
-tr.Processes.Default.StartBefore(ts)
+tr.Processes.Default.StartBefore(ts, ready=When.PortOpen(ts.Variables.port))
Review Comment:
You were right, and thanks for calling this out. I removed the
`thread_config` PortOpen-based readiness change from this PR so ATS startup
gating remains tied to the existing fully-initialized readiness behavior. I
also retitled/scoped this PR to only the `post`/`slow_post` autest fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
